From: Marco Trevisan (Treviño) <mail@3v1n0.net>
Date: Wed, 17 Sep 2025 17:06:55 +0000 (+0200)
Subject: gdm/util: Do not run dispose on user verifier
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~39^2~1^2~15
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=7029cf41f1265a50009c237045aa36d73be1165b;p=gnome-shell.git

gdm/util: Do not run dispose on user verifier

This is not a good habit anywhere and especially in JS code, I assume
the rationale for this was to ensure that cached instances of the proxy
were cleared, but this did not work properly (as it happened on
finalize), and it would still require [1].

So let's just avoid this and assume that the getters just return what we
expect.

[1] https://gitlab.gnome.org/GNOME/gdm/-/merge_requests/321

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3885>
---

diff --git a/js/gdm/util.js b/js/gdm/util.js
index 3334d61f0..d7339c140 100644
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -201,12 +201,8 @@ export class ShellUserVerifier extends Signals.EventEmitter {
         if (this._userVerifier) {
             this._disconnectSignals();
             this._userVerifier.get_connection().disconnectObject(this);
-            this._userVerifier.run_dispose();
             this._userVerifier = null;
-            if (this._userVerifierChoiceList) {
-                this._userVerifierChoiceList.run_dispose();
-                this._userVerifierChoiceList = null;
-            }
+            this._userVerifierChoiceList = null;
         }
     }